adamzzq / pe

0 stars 0 forks source link

Transaction amount overflow #2

Open adamzzq opened 2 months ago

adamzzq commented 2 months ago

image.png

As shown, the amount borrowed by charlieputh is not correctly displayed upon checking it by lm command, despite successfully added that amount. Maybe you could prevent such large amount from being added in the first place by adding a limit-checking mechanism for the transaction amount.

soc-pe-bot commented 2 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Duplicate of #2044 as it concerns how we handle large inputs and our lack of measures to prevent large values from being input.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Incorrect owed amount shown when adding large numbered transactions

image.png

This may be a problem if I am given an incorrect amount to take note of as debt for managing large debts.


[original: nus-cs2113-AY2324S2/pe-interim#2439] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We accept this bug, but think it should be of a severity of low as it is unlikely to affect normal operations since the application is designed for transactions within groups and transactions within friends is unlikely to reach the amounts as tested.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]