search

adamzzq / pe

0 stars 0 forks source link

DG sequence diagrams wrongly labeled #5

Open adamzzq opened 2 months ago

adamzzq commented 2 months ago

image.png

image.png

image.png

image.png

The transactionList, memberList, and group are all illustrated in a way such that they return a value to the caller. But from the class diagram, it is interpreted that they return void when adding new items to the List.

nus-se-script commented 2 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

We accept this issue but have decided to lower the severity to Low as we feel it does not impede the readers' understanding of the program flow.

We feel that multiple bugs have been reported within this issue and have decided to omit the issue pertaining to group as it is trivial - getter methods do indeed have return values and have been omitted from the class diagram for brevity.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]