Proxenos not giving +2 gold to Capital

[IllusVirus]

If I understood it correctly, Proxenos is supposed to give +2 gpt to Capital for completing diplo missions, which it does not seem to be doing. If it meant it adds +2 more gold to the 1 gold given by diplo missions, that does not seem to be working either.

Love this mod mod btw, gave VP a breathe of fresh air

[pineappledan]

This promotion can be hard to test, because the reduction in unit maintenance immediately after expending a diplomat makes it appear that it is working. Check the capital to make sure the gold income of the city is increasing

What version of the modmod are you using?

The Proxenos promotion was broken in previous versions (up to v31, I believe) but should be fixed in the most up-to-date version.

[IllusVirus]

I believe I am on the latest one, I do recall downloading 32.2, but when I 'install' it I noticed that it says its v32, unless the mini versions are never indicated. The changelog has no indication of the fix, but I suppose its not significant enough to be mentioned.

I also did check the capital and even waited some turns to see if it updated eventually, but no dice so... yeah.

I'll attempt to re-install and see if that fixes it. Thank you.

[pineappledan]

The fix was made in mid April, so you definitely a version that is up to date.

I will try to replicate it on my end this weekend

[IllusVirus]

Okay. I'll try things again too on my end. Thanks again!

[pineappledan]

Gave it a go on my end. Proxenos promotion is not working, just as IllusVirus said.

My logs don't show any errors, which I suppose means that the trigger is not firing, or the trigger is firing, but is failing a check. Logs.zip

[Infixo]

Proxenos uses UnitPrekill event which needs to be enabled first by setting EVENTS_UNIT_PREKILL to 1.

[pineappledan]

grr.... That was in there before... Who removed it? Added and currently testing

[adaneslavo]

Close?

[pineappledan]

I still haven't gotten around to testing it :(

[adaneslavo]

Ouch! :]

[pineappledan]

Can confirm that this issue has NOT been resolved

[adaneslavo]

I will look into it then.

Why Proxenos only boosts capital after diplo missions in MINOR civs?

[adaneslavo]

It can see the unit, but is unable to see promotions on that unit. I had same problem with "Diplomatic Reciprocity" when I wanted to check if the unit is creating embassy or doing normal mission. I cannot because the unit had no coordinates or something. So i did it only to work as now.

I checked but there's no diplo events like "OnGreatPErsonExpensanded" I used in DR. Change?

[adaneslavo]

I made it work. The only thing hat concerns me is how to differentiete diplomatic mission from death on foreign territory? Code will not see the difference.

[pineappledan]

So right now it check if eCiv ~= -1, so it will trigger as long as the unit dies in non-neutral territory.

Does this mean the only thing that was going wrong was the IsMinorCiv() check?

What happens if we change that to "if eCiv >= 22"?

According to this section of the modiki, civ number between 22 and 63 are reserved for city-states

[adaneslavo]

I changed also promotion name. It was wrong. I deleted minor civ because on main page there was no info that it should work only for CSs. I made it work for all civs. I think this function trigger when unit dies or is expended. Then it is treated as "dead". I suppose. It needs to be checked, I cannot do that in next 36 hours at least.

[pineappledan]

The promotion is only given to diplomatic units. There's no way to have them die in a mojor civ's territory except to have them get captures, or to delete them.

I think it is best to keep the minor civ check, if possible

This is what the Proxenos promotion says it does: +5 Influence and +2 Gold in Capital on completion of Diplomatic Mission.

I can't think of why we would want the proxenos to trigger in a major civ's territory if we can help it.

[adaneslavo]

So the check is unnecessary if diplo units can be used only on cs.

[pineappledan]

Without the check, it is possible to trigger the +2g in the capital by having your diplo unit get captured or deleted in another civ's territory.

Technically, this check wouldn't prevent the trigger if the unit were captured/deleted in a CS's territory, but we would assume that if a diplo unit is inside a CS territory, it is going to expend itself with a diplo mission.

Overall, I'm fairly unconcerned with the issue. The chances that people are going to delete a unit like this, or get it caught on purpose is remote, since they would be missing out on 35 influence, but if it can be easilly done, and the minor civ check doesn't cause any issues, then it may as well stay

[adaneslavo]

Ok.

[adaneslavo]

Change description on main site. Also Barbican had some tab issue after your last update :P