search

adaneslavo / More-Unique-Components-for-VP

Adds 3rd and 4th unique component to each civilization.
1 stars 6 forks source link

Inconsistency between unit's yields from barbarian kills #156

Closed Phalanx1 closed 6 years ago

Phalanx1 commented 6 years ago

I've already explained the issue in a comment here, I'm just submitting this issue to make things more organized.

pineappledan commented 6 years ago

This needs to be tested. Both of the promotions are supposed to give double yields if the unit killed was a barbarian.

So, if a barbarian is killed, and UnitPromotions_YieldFromKills and UnitPromotions_YieldFromBarbarianKills are both set, does the game count each separately? Or does the game look for the highest value, and only count it as one kill?

Right now, both of the promotions are set at 75 for UnitPromotions_YieldFromKills and 150 for UnitPromotions_YieldFromBarbarianKills. If we want the yields on kills to be doubled for barbarians, do we A) set UnitPromotions_YieldFromBarbarianKills to 75 (75+75 = 150), or b) set UnitPromotions_YieldFromBarbarianKills to 150 (150 + 75 0 = 150 )?

I have tried playing a game with India with UnitPromotions_YieldFromBarbarianKills = 150, and it appears that kills give 150% of barb kills as yields, and not 225% (75+150). I was not looking for this problem, however, so I did not look directly at the culture counter in the top, to determine if the kill was being double-counted. It is possible that, since they are 2 of the same yield, the floating text was overlapping, and so I didn't see 2 instances of culture on the kills. Paging Adam

Phalanx1 commented 6 years ago

What you said is incorrect, unless I misread the code. For the Indian UU, both YieldsFromKills and YieldsFromBarbarianKills are set at 75, while on the Polish one YieldsFromKills is set at 150 and YieldsFromBarbarianKills is set at 300. As for which one is correct, I have no idea. Edit: btw, I am taking your Indian Archer fix from July 3rd into account when stating this.

pineappledan commented 6 years ago

I played a game with India where yields from kills were set to 75, and barbarian kills were set to 150. Bogurodzica is set at 150 and 300, yes. I misspoke, but the issue remains: If we want 2x yields from barbarians, do we get X from a kill + Y from a BarbKill, or does the game just give yields for whichever value is set higher, and ignore the lower value?

Phalanx1 commented 6 years ago

I can't test right now, if I have time I'll run a quick India game and tell you the result.

pineappledan commented 6 years ago

Thanks for checking.

You'll have to look at your total culture in your policy progress meter.

If the culture is being double-counted, it is not showing up in the floating text on kills. I can tell you that much at least.

pineappledan commented 6 years ago

I tested it. yieldFromKills=75 YieldFromBarbarianKills = 150 killed a barbarian (7 CS). The resulting culture was 15 (7*2.25, rounding down)

I deduce from this that the proper setting for this is for barb kills to be 75, and yield on kills to be 75.

I will now consider the matter closed