adaneslavo / More-Unique-Components-for-VP

Adds 3rd and 4th unique component to each civilization.
1 stars 6 forks source link

German Teutonic Order problems #184

Closed UndeadDevel closed 5 years ago

UndeadDevel commented 5 years ago

Version: v38

Error Description:

There are two issues here:

  1. While the description states that only new units will get the Morale promo from Barracks after building the TO, it was actually all units that had been built in cities with Barracks in the past. So either the description or the behavior should change (I would prefer the former).

  2. The Defense bonus that Barracks are supposed to get with TO seems to only apply to cities with Barracks that existed when the TO was built or that are built regularly after the TO is built. Cities with Barracks "pre-built" i.e. cities that are founded with Pioneers (I have not tested Colonists) do not get the defense bonus. I wasn't able to verify whether the HP bonus has the same issue.

Overall I would prefer if all units built in cities with Barracks got Morale and all new Barracks got the Defense bonus, but the latter one takes the priority I would say.

Enrico-Swagolo commented 5 years ago

Barbies gotten before TO is built receive the Morale, while those afterwards don't. Handaxes with hillwalkers/treewalkers/desertwalkers/skinwalkers or whatever the barbie promos are called and Morale are pretty sweet, a shame there'll be less time to get some now.

pineappledan commented 5 years ago

Interesting... Well that's a strange easter egg, but it's of little consequence. I have cleared the text error and added a lua hook for barracks dummies on city founding