search

adaneslavo / More-Unique-Components-for-VP

Adds 3rd and 4th unique component to each civilization.
1 stars 6 forks source link

Iron chariot lua changes. #28

Closed adaneslavo closed 6 years ago

adaneslavo commented 6 years ago

Remove player do turn event. Verify if on create or on train functions are needed. Probably yes.

adaneslavo commented 6 years ago

Ok, I checked why for me onMove trigger didn't work. I can tell you that is because I need to check if adjacent unit has some promotion. When you create one and take scan for adjacent units it treats newly created one like it wouldn't have any promotion. You for Iron Chariot check only for some unit and don't bother with promotions.

pineappledan commented 6 years ago

So this is resolved then? In any case is this not the same error as the plot iterator issue?

adaneslavo commented 6 years ago

No. Plot iterator can be in any file using it or in plotiterator itself. I resolved 3 other lua bugs in your files when there was using pAttackingUnit:function and there was no such unit (nil).

adaneslavo commented 6 years ago

Delete playerdoturn event and check if it is fine. I think it is useless now, but had no time to check that.

adaneslavo commented 6 years ago

I reworked this code. I found situation where Iron Chariot didn't get bonus from Fury of Nergal. F.e. 3 barbs and then between them Iron Chariot is Created. No effect on him.