search

adaneslavo / More-Unique-Components-for-VP

Adds 3rd and 4th unique component to each civilization.
1 stars 6 forks source link

Unit creation sequence #61

Closed Infixo closed 6 years ago

Infixo commented 6 years ago

When unit is created in the city (trained or purchased) 3 events are triggered:

  1. UnitSetXY
  2. UnitCreated
  3. CityTrained

When unit is created not in the city 2 events are called:

  1. UnitSetXY
  2. UnitCreated

Please be careful of applying multiple effects. Affects: Monitor, Iron Chariot, Landwehr, Ballista, Seir Morb, Goedendag

adaneslavo commented 6 years ago

What changes do you suggest to reduce their overlapping job?

Infixo commented 6 years ago

Depends on situation. If an effect is to be apllied for units trained or purchesed in cities - use CityTrained. If an effect is to aplied to any unit created, no matter how - then use UnitCreated.

Infixo commented 6 years ago

I’d say default should be CityTrained, as this is the main source of units in game. UnitCreated only if really necessary.

adaneslavo commented 6 years ago

What about units gifted from city-states? Every unit could be trained or gifted from CS, so both function are always needed.

pineappledan commented 6 years ago

This also affects Yamato. I agree with Adan, UnitCreated sounds like it should be the natural default, since this captures events, policies, and CS gifts. Goedendag, for instance, could be created through the last authority policy without being trained.

adaneslavo commented 6 years ago

I suppose we cannot do anything with this to simplify it more. Closing issue.