adang1345 / PythonWin7

Python 3.9+ installers that support Windows 7 SP1 and Windows Server 2008 R2
MIT License
545 stars 65 forks source link

May be integrate VirusTotal check? #4

Closed andry81 closed 1 year ago

andry81 commented 1 year ago

Here is a solution through the GitHub Actions pipeline: https://github.com/crazy-max/ghaction-virustotal

Direct API: https://github.com/VirusTotal

adang1345 commented 1 year ago

What would be the benefit to this?

andry81 commented 1 year ago

What would be the benefit to this?

Already checked for viruses.

adang1345 commented 1 year ago

I feel as though not much would be gained if I were to integrate a virus check on my side. A user who's really concerned about viruses shouldn't trust virus scan results reported by the uploader of a file because those results could be manipulated. Rather, the user should run his or her own virus scan.

andry81 commented 1 year ago

That is anyway better than a user check on it's own.

adang1345 commented 1 year ago

I've decided not to do this. No user should trust virus scan results that I report, so integrating VirusTotal offers minimal security. Users who are concerned about viruses should perform their own scans. Users who are extremely concerned about viruses should not download these files at all. I have included some notes in the repository for how I built these installers, so users that do not trust these files at all can build them on their own machines instead.

andry81 commented 1 year ago

Just for instance, there is another way - upload files into fosshub.com. Example: https://www.fosshub.com/qBittorrent.html