search

adang1345 / delvewheel

Self-contained Python wheels for Windows
MIT License
116 stars 12 forks source link

Ignoring .pyd files in data/ directory #43

Open sharm294 opened 7 months ago

sharm294 commented 7 months ago

Hi,

I saw this commit changed the behavior to ignore .pyd files in the data directory outside of two specific directories. Could you elaborate on why this change was made?

Also, would you have any insight on how to export a package out of CMake that would place the .pyd files in the structure expected by delvewheel? Right now, I'm using the release prior to the above change and the .pyd files get exported relative to data/. I set the LIBRARY DESTINATION for the install() to lib/site-packages/<name>.libs so they get extracted to the same directory as the dependent DLLs that delvewheel adds into the wheel when it finds the .pyd files.

adang1345 commented 6 months ago

The .data directory supports 5 subdirectories: purelib, platlib, headers, scripts, and data. I am aware of use cases where .pyd files are placed in purelib and platlib, but I am not aware of use cases for putting .pyd files in the other 3 subdirectories. My understanding is that the data subdirectory is typically used for data files rather than Python code files, which is why I made the change to ignore it.

I am not familiar with CMake, so I can't help with that aspect.