search

adang1345 / delvewheel

Self-contained Python wheels for Windows
MIT License
123 stars 12 forks source link

🩹 fix free-threading support #50

Closed burgholzer closed 3 months ago

burgholzer commented 3 months ago

This tiny PR adds free-threaded python to ignore_regexes. Without this fix, delvewheel would not ignore python313t.dll and would patch it in the wheel which, subsequently, leads to access violations when trying to import the repaired wheel.

Given that I am not too familiar with the delvewheel codebase, I am not sure if there are other places where this needs to be fixed. At least a local test run with a free-threading build confirmed this to be working.

adang1345 commented 3 months ago

Thanks! This should be all that's needed to fix the issue.

burgholzer commented 3 months ago

Nice. Thanks for merging so quickly! Would it be possible to get a release with this fix out? Happy to contribute the corresponding PR if you'd like.

adang1345 commented 3 months ago

I'll make a new release after fixing #49. It shouldn't take too long.

adang1345 commented 2 months ago

New release is out.