Large Refactor - Githubissues

adangert / JoustMania

Raspberry Pi Jousting at its finest

http://joustmania.com

Other

124 stars 34 forks source link

Large Refactor #317

Closed mchirlin closed 8 months ago

mchirlin commented 9 months ago

Refactoring

Moving all games to use a common class: games.game
Reusing as much code as possible across games
Added logging to file throughout
Removed a lot of duplicate type variables - moved all game_opts to a single variable

Bug Fixes

Enhancements

Adding end game sounds to all of the games
286
281
179
162
19
16

adangert commented 9 months ago

Thanks! Next time that I have some spare time, I will test out the code changes, are you using bookworm or bullseye for the raspberry pi OS btw?

mchirlin commented 9 months ago

I think it's bullseye.

adangert commented 8 months ago

Fantastic work!! Just went through the code, and was able to test all the game modes, There were a couple of bug fixes that I was able to find and update as well. But all the new code is much cleaner with way less DRY code everywhere. Thanks so much for all the help!

adangert / JoustMania

Large Refactor #317

Refactoring

Bug Fixes

314

Enhancements

286

281

179

162

19

16