search

adanvdo / YT-RED-UI

Windows .NET Framework GUI Application for Downloading Video and Audio Files from YouTube and Reddit
48 stars 1 forks source link

After Reddit Gif Support in Issue #2 and #62 Some Reddit GIF (Video Only) posts are still broken #89

Closed adanvdo closed 2 years ago

adanvdo commented 2 years ago

see issues #2 and #62 There appear to be some specific gif/mp4 formats that are not working with the app. These particular posts do not return any available formats, and cannot be saved directly in the browser.

Example Post: https://www.reddit.com/r/maybemaybemaybe/comments/w2ypa5/maybe_maybe_maybe/

Inspection Shows the following HTML 

<video loop="" preload="metadata" class="_1EQJpXY7ExS04odI1YBBlj" style="background-color: rgb(0, 0, 0);" flashstopped="true" id="dummyid31" src="blob:https://www.reddit.com/02ea5bcf-fe72-484c-93df-4d15044cf017">
<source src="https://v.redd.it/7vf635gmslc91/HLSPlaylist.m3u8?a=1660850935%2CZGU0OGY3ZWZiOWM4M2NlOGNmNWVhZDg2M2VlNDJiMzEyNWE3ZDc0Njc1NDA3ZTA5N2JiZTU4NzY5NjdjZTZiNw%3D%3D&amp;v=1&amp;f=hd" type="application/vnd.apple.mpegURL">
</video>

Here is a the html for a supported GIF post for comparison

<a href="https://preview.redd.it/st4kv9ga0jc91.gif?format=mp4&amp;s=8300090f2d3bdbf43d0154ab0114bb3af4b5530e" target="_blank" rel="noopener noreferrer" flashstopped_p="true">
    <video class="media-element tErWI93xEKrI2OkozPs7J" height="512" loop="" width="384.15005861664713" style="margin: 0px auto; max-height: 700px;" flashstopped="true" id="dummyid68" preload="metadata">
        <source src="https://preview.redd.it/st4kv9ga0jc91.gif?width=640&amp;format=mp4&amp;s=43549cb36a357394180e6f908e35ba25fb0df212">
    </video>
</a>

I cannot easily confirm, but one of the posts may be utilizing reddit's "Make Gif" feature that is available after uploading a video, or it could be a difference in platform (i.e. posting the media from an apple device as opposed to PC/android)

adanvdo commented 2 years ago

I have added fallback code in the case where reddit media does not contain an audio stream. This fallback solves the above problem, but it currently limited to the mainform.

These implemented fixes and workarounds need to be duplicated in the tray form for quickdownloads.

adanvdo commented 2 years ago

I have implemented gif support in the tray form. it is working as of now