adaorachi / js-todo-app

A to-do list app built with JavaScript
1 stars 1 forks source link

Recommendations from 40 the silicons #2

Open sebastianlujan opened 4 years ago

sebastianlujan commented 4 years ago

Hello Team 👋! Your project looks amazing, very professional look and feel, and your code is well organized and compact, !

Some considerations to have in mind

For aestetics, maybe is better to increase padding left and right on buttons that increase the negative space and integrate better the shape and the size on the whole app.

Screen Shot 2020-04-10 at 12 05 00 PM

On responsive:

Screen Shot 2020-04-13 at 8 03 46 PM

maybe a floating hamburger button, and hide the aside panel, and increase width is a good way to go

The code modularity looks nice and powerful, we love the good use of webpack this project is great for apply the MVC pattern, but we know you will use it , in react. Always remember the patterns allows you to organize the code and extend it in the future. Great work and keep coding 🚀

sebastianlujan commented 4 years ago

I will review deeply the code beyond the aesthetics, to help you with great coding practices, stay tune