adap / flower

Flower: A Friendly Federated AI Framework
https://flower.ai
Apache License 2.0
5.08k stars 875 forks source link

FedNova #2011

Closed jafermarq closed 10 months ago

jafermarq commented 1 year ago

FedNova

Do you want to work on this baseline?

🌻 Check everything about the Summer of Reproducibility on flower.dev/summer

All available baselines are listed in the Summer of Reproducibility Dashboard and also in the GitHub Issues with the summer-of-reproducibility label. The content is the same.

📝 It is advised to complete these steps before your start working on your code. But if you can't wait to implement your baseline with Flower (we totally understand it 😄), please ensure you follow the steps on how to contribute a new baseline.

What follows are the steps 1 & 2 in the Summer of Reproducibility instructions.

1. Join the Summer of Reproducibility program

What happens next?

Is something wrong or not clear ?

ashdtu commented 1 year ago

Hi @jafermarq I would like to implement the FedNova baseline in the Flower framework.

Contribution plan

Experimentation/Datasets I plan to reproduce experiments proposed in the paper on the Synthetic(1,1) dataset (with alpha, beta = 1) and further on a Non-IID version of CIFAR-10 dataset. The experiments would involve performance comparison between FedAvg, FedProx and this work FedNova).

My Background I am currently a MSc Computer Science student at MILA-Quebec AI Institute, Montreal. It is one of the leading institutes in AI research. I am based in Canada and hence in the list of eligible countries.

Would love to discuss further and get started. I am on Flower slack as(@ ash, Aasheesh Singh)

jafermarq commented 1 year ago

Hi @ashdtu, it's great to hear you want to reproduce the results in FedNova. Also, thanks for the very complete message addressing all the points. Just one small clarification about your contribution plan is to replicate Figure 5 and Table 1 ?

ashdtu commented 1 year ago

Yes @jafermarq that's correct. Fig 5 corresponds to Synthetic(1,1) experiment and Table 1 for CIFAR 10 dataset.

jafermarq commented 1 year ago

Great! thanks for the clarification. I've ✅ all the points above for Steps 1 & 2 and add you as the assignee to this issue. I also moved this FedNova baseline to "In Progress". You can find first steps on how to start working on your baseline via the link in the What happens Next section in the issue description.

Looking forward to see FedNova in action!

ashdtu commented 1 year ago

Draft PR : https://github.com/adap/flower/pull/2179 for progress

jafermarq commented 10 months ago

Congratulations @ashdtu your baseline has been merged. We'll follow up with you soon to complete your Summer of Reproducibility journey 😄 !