break(framework) Fix simulation arguments and tests

chongshenng commented 4 days ago

The existing Exec API tests are silently failing, causing several bugs to slip through. The changes in these PR are inter-related.

For tests:

Fix Exec API tests so that it succeeds (exit 0) or fails (exit 1) correctly.
Remove unsupported --executor-config num-supernodes=1 from flower-superlink which was removed in #4486.

For flwr-simulation arguments:

Update SuperLink to call flwr-simulation with --simulationio-api-address instead of --superlink.
Remove secure connection for flwr-simulation.

For settings in flwr-simulation:

Set the default value of enable_tf_gpu_growth in flwr-simulation to False on line 234. @jafermarq can you please confirm that this fix is reasonble?

jafermarq commented 3 days ago

@chongshenng could we follow the same logic in flwr-simulation as in flwr-serverapp and introduce something like this? https://github.com/adap/flower/blob/67688c6708b3cf23829c872999c0f9887b9ed558/src/py/flwr/server/serverapp/app.py#L74

chongshenng commented 3 days ago

@jafermarq For this comment, yes. I'll have a follow-up PR that refactors the args and includes this warning too.

adap / flower