search

adapt-it / adapt-it-mobile

Translate between related languages on your mobile device.
https://adapt-it.github.io/adapt-it-mobile/
MIT License
27 stars 8 forks source link

Android: remove READ_EXTERNAL_STORAGE permission #555

Closed eb1 closed 7 months ago

eb1 commented 7 months ago

Describe the bug This is a follow-up to issue #550 .

It looks like the READ_EXTERNAL_STORAGE permission is no longer used in Adapt It Mobile and can also be removed (users can still see and open items on their external storage with the file chooser mechanism that was introduced in AIM 1.14.0). This issue is to track the removal of the permission from Android.

IzzySoft commented 7 months ago

Still shows up with today's update btw, so something brings it back in. If you're sure it's not needed, you can try Removing Unwanted Manifest Permissions With tools:node maybe.

eb1 commented 7 months ago

@IzzySoft Ugh. Looks like it snuck back in when I updated Android Studio last week. I've re-posted the .apk to the 1.16.0 milestone release, and added a note to myself to recheck this prior to each release, just in case... Thanks for catching this!

IzzySoft commented 7 months ago

I forward the thanks to my scanner, which reported it to me. (background noise) OK, scanner says I shall keep the glory as it was me who taught it to :man_shrugging: So thanks for keeping up with our reports then! :star_struck: