search

adapt-security / adapt-authoring-ui

Frontend user interface of the Adapt authoring tool
1 stars 2 forks source link

Copy and Paste not working as expected. #271

Closed joe-allen-89 closed 9 months ago

joe-allen-89 commented 10 months ago

What happened?

Currently the copy and paste function seems to not be working as expected.

When copying a component to an empty block, clone fires as expected, but on page reload no component is visible. When copying an article/block/page with content the article/block/page is duplicated as expected but non of the children are. No console/network errors.

When throttling you are also able to press copy/paste multiple times before the first request is completed, this leads to an error saying "unable to fetch course data", this then crashed the testing site for me with numerous errors, screenshots below.

@taylortom - just an fyi tag.

image

image

Steps to reproduce

Create a course and attempt to copy and paste both with and without throttling.

Authoring tool version

rc.4

taylortom commented 10 months ago

It's been ascertained that the existing UI work cannot be merged due to its reliance on the no-sidebar branch, so any fixes will need to be done to master separately

taylortom commented 10 months ago

It's been agreed that we'll revert the changes to ContentModule for now.

chris-steele commented 10 months ago

@joe-allen-89 as this functionality was never officially supported or tested in master this can probably be put as a non-issue and closed I'd say? It will be released with v1.1 with the new UI all being well and it has been regularly tested as working in that branch.

joe-allen-89 commented 10 months ago

@chris-steele I was thinking we keep this open until the reverted changes have been tested, and we're happy there's no issue, just to be safe, but agree the v1.1 release should be fine as it has been tested with it.

FYI - @taylortom