adapt-security / adapt-authoring-ui

Frontend user interface of the Adapt authoring tool
1 stars 2 forks source link

Search by tag not restored after search by name #291

Open chris-steele opened 1 week ago

chris-steele commented 1 week ago

What happened?

I filtered courses using search by tag. I then filtered courses using search by name, which overrides search by tag (it is not a compound filter). The tag parameter I chose remains, however.

When I cleared the search by name parameter, the results were not filtered by tag, despite the tag parameter remaining.

Expected behaviour

When I search by name any selected tags should be removed (or vice versa).

OR

The filter should be compound: i.e. if there are tags selected and a parameter given to search by name then the matching courses should satisfy both queries.

taylortom commented 1 week ago

I would expect the filters to remain applied until removed (or on navigate away)

chris-steele commented 1 week ago

@taylortom should courses be filtered by tag AND name or should name continue to override tag?

taylortom commented 1 week ago

Yes, I think all applied filters should be working together

taylortom commented 1 week ago

Have discussed, and the following was agreed: