search

adapter-hub / adapters

A Unified Library for Parameter-Efficient and Modular Transfer Learning
https://docs.adapterhub.ml
Apache License 2.0
2.58k stars 347 forks source link

PLbart support #709

Closed FahadEbrahim closed 4 months ago

FahadEbrahim commented 4 months ago

Hi,

This is a PR to add the PLBART model written in the following paper. The original code is available at the following link. It follows the BART architecture, so, I followed the same style.

This is my first PR, so apologies in advance for any errors and I'd appreciate your feedback and guidance.

Thanks, Fahad.

calpt commented 4 months ago

Hey @FahadEbrahim,

Thank you so much for working on this! We'll look into your PR more closely in the coming days. In the meantime, it would be great if you could continue to work on making the failing checks passing and let us know if you need any help on that!

FahadEbrahim commented 4 months ago

Thank you @calpt for your kind reply.

The testing of the models and the methods were successful. But I'd appreciate your review conceptually (if there are differences between PLBart and BART that I'm unaware of)

I was having an issue with the first test of code quality. It was due to not cloning the repo recursively. It's been fixed now.

FahadEbrahim commented 4 months ago

Thank you @calpt for reviewing the PR. The conflict has been fixed. Please let me know if anything can be modified.