adapter-hub / hgiyt

Research code for the paper "How Good is Your Tokenizer? On the Monolingual Performance of Multilingual Language Models"
https://arxiv.org/abs/2012.15613
26 stars 6 forks source link

finetuning: add missing use_fast arg to argument parser #1

Closed stefan-it closed 3 years ago

stefan-it commented 3 years ago

Hi guys,

I'm currently using this great repo for re-evaluating all my models in the Turkish LM model zoo.

When using the fine-tuning script for sentiment analysis, I just found out that the use_fast argument is not added to the hf argument parser, and this throws an execption later, when it will be used:

https://github.com/Adapter-Hub/hgiyt/blob/9db6b6d1aab264cdf9e3131adb8157bcaf162410/finetuning/sa/run_sa.py#L141

This PR fixes it :)

stefan-it commented 3 years ago

/cc @JoPfeiff and @xplip

xplip commented 3 years ago

Hi Stefan, thanks for catching this :). It seems I deleted the argument when cleaning up the code and missed the dependency below.