adaptive-cfd / WABBIT

Wavelet Adaptive Block-Based solver for Interactions with Turbulence
https://www.cfd.tu-berlin.de/
GNU General Public License v3.0
55 stars 27 forks source link

Merger with some earlier developments #37

Closed dkolom closed 4 years ago

dkolom commented 4 years ago
dkolom commented 4 years ago

Please merge while this can be done automatically.

dkolom commented 4 years ago

No, no reason. If the original works in all cases, let's get it back. But please check. Many postprocessing routines apparently stopped working after the changing for new ghost nodes and tree forest, I tried to fix that.

On Tue, Aug 25, 2020, 9:33 PM Thomas Engels notifications@github.com wrote:

@tommy-engels commented on this pull request.

In LIB/POSTPROCESSING/post_stl2dist.f90 https://github.com/adaptive-cfd/WABBIT/pull/37#discussion_r476411810:

  • call create_active_and_sorted_lists( params, lgt_block, lgt_active, &
  • lgt_n, hvy_active, hvy_n, lgt_sortednumlist, tree_n)

This change is a bit odd to me: the original call updates all active and sorted lists, for all trees, while the pull request specifically updates only tree #1 https://github.com/adaptive-cfd/WABBIT/pull/1

is there a reason for doing this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/adaptive-cfd/WABBIT/pull/37#pullrequestreview-474433124, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABENQFD26V3OBUJMHLXFTE3SCOVQLANCNFSM4QKFH6HA .