adaptive-intelligent-robotics / QDax

Accelerated Quality-Diversity
https://qdax.readthedocs.io/en/latest/
MIT License
258 stars 42 forks source link

fix: dependencies in notebook examples #149

Closed Lookatator closed 1 year ago

Lookatator commented 1 year ago

Solves issue #148

This PR introduces:

Checks

Future improvements

Shall we only use Jumanji in its corresponding file? (and remove the Jumanji import from types.py) This way, we could use QDax brax environments (and others) without having to install Jumanji

limbryan commented 1 year ago

Agree for the future improvements for the Jumanji requirement. We can try to use the install with brackets like is done for gym (i.e. pip install gym[mujoco]). But let's do this in another PR!

codecov-commenter commented 1 year ago

Codecov Report

Merging #149 (b07d1a7) into main (773e646) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         116      116           
  Lines        6763     6763           
=======================================
  Hits         6241     6241           
  Misses        522      522           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more