search

adaptive-learning / flocs

Intelligent application for learning computer science.
GNU General Public License v2.0
1 stars 5 forks source link

Upgrade Angular and other frontend packages #109

Open effa opened 8 years ago

effa commented 8 years ago

Having newer version of angular-bootstrap probably solves "srolbar flash" bug in uib-collapse which is why we are using deprecated collapse in header.tpl.html. But newer version of angular-bootstrap require newer Angular (>= 1.4) and there are several others packages dependant on Angular version, so they will need update as well + careful testing that nothing is broken.

effa commented 8 years ago

Concerning the "deprecation message", I have solved this by using ng-class instead of the full uib-collapse: https://github.com/effa/flocs/commit/da0bde72b8935cd209e4fd5b70d4d7b560c84b80#diff-54664e75a7fa3f8d262b1eadf7b00058R21

As a consequence, the responsive menu is not animated, but it's maybe even better that way (because e.g. dropdown buttons with the menu are not animated as well, so at least it's consistent behavior).