Open jsbronder opened 10 years ago
:+1: from me. Justin is absolutely correct from a distribution/packaging perspective. The bytes saved by excluding the tests are, in my opinion, insignificant in comparison to the loss of functionality in not being able to run the test suite. (Note that RPM has a %check section in spec files specifically for this reason, which I hope will illustrate how common and desirable this is in packaging.)
6 months, any chance of this happening?
Justin,
Thanks for the ping on this. We will bring it up in our next meeting.
Ken
On Mon, Apr 20, 2015 at 9:51 AM, Justin Bronder notifications@github.com wrote:
6 months, any chance of this happening?
— Reply to this email directly or view it on GitHub https://github.com/adaptivecomputing/torque/issues/284#issuecomment-94491295 .
[image: Adaptive Computing] <http://www.adaptivecomputing.com>
[image: Twitter] http://twitter.com/AdaptiveMoab [image: LinkedIn] http://www.linkedin.com/company/448673?goback=.fcs_GLHD_adaptive+computing_false_*2_*2_*2_*2_*2_*2_*2_*2_*2_*2_*2_*2&trk=ncsrch_hits [image: YouTube] http://www.youtube.com/adaptivecomputing [image: GooglePlus] https://plus.google.com/u/0/102155039310685515037/posts [image: Facebook] http://www.facebook.com/pages/Adaptive-Computing/314449798572695?fref=ts [image: RSS] http://www.adaptivecomputing.com/feed Ken Nielson Sr. Software Engineer +1 801.717.3700 office +1 801.717.3738 fax 1712 S. East Bay Blvd, Suite 300 Provo, UT 84606 www.adaptivecomputing.com
So, I can't fix other things that are broken in the configure scripts because this still persists.
I'd pull from github directly, but despite http://www.supercluster.org/pipermail/torquedev/2013-May/004519.html there's still not any tagging happing on a consistent basis.
Really, at this point I'm just going to drop Torque from Gentoo if you guys can't figure out a way to provide reasonable releases. I know this probably sounds a bit harsh, but come on, this was raised in 2013.
Justin,
I think I have the ball rolling. I know we have been slow but can I beg for a little more time from you?
Ken
Ken, I think it might be helpful if you could provide a cut-and-paste here of the sequence of commands you all use to generate a release tarball. It should be something very similar to ./autogen.sh && make distcheck
, but if we could at least see how you're currently doing it, we might be able to suggest alterations that would ensure that the needed files were present in the resulting tarballs.
Is that doable?
I am adding David Beer to this thread.
On Wed, Aug 5, 2015 at 4:29 PM, Michael Jennings notifications@github.com wrote:
Ken, I think it might be helpful if you could provide a cut-and-paste here of the sequence of commands you all use to generate a release tarball. It should be something very similar to ./autogen.sh && make distcheck, but if we could at least see how you're currently doing it, we might be able to suggest alterations that would ensure that the needed files were present in the resulting tarballs.
Is that doable?
— Reply to this email directly or view it on GitHub https://github.com/adaptivecomputing/torque/issues/284#issuecomment-128170548 .
[image: Adaptive Computing] http://www.adaptivecomputing.com [image: Twitter] http://twitter.com/AdaptiveMoab [image: LinkedIn] http://www.linkedin.com/company/448673?goback=.fcs_GLHD_adaptive+computing_false_*2_*2_*2_*2_*2_*2_*2_*2_*2_*2_*2_*2&trk=ncsrch_hits [image: YouTube] http://www.youtube.com/adaptivecomputing [image: GooglePlus] https://plus.google.com/u/0/102155039310685515037/posts [image: Facebook] http://www.facebook.com/pages/Adaptive-Computing/314449798572695?fref=ts [image: RSS] http://www.adaptivecomputing.com/feed Ken Nielson Sr. Software Engineer +1 801.717.3700 office +1 801.717.3738 fax 1712 S. East Bay Blvd, Suite 300 Provo, UT 84606 www.adaptivecomputing.com
We do build as you imagine. I know how to make the check files included as well, this just got lost in the shuffle. We can take care of this soon.
As a distribution packager it's very nice to be able to run unittests that verify I haven't broken anything while performing said packaging. I also have many users who like to run tests to make sure that their system build the package correctly and to verify my packaging.
Related to the fact that tests are not part of the distributed tarball, the configure scripts all cannot be regenerated (autogen.sh). This means that I can't apply any patch which touches the build system which is pretty common when getting a package to conform to the distribution rule (install locations, using system libraries etc.)
Please readd the tests and anything else referred to by the autotools.