search

adaptlearning / adapt-cli

Command line and library interface for the Adapt Framework
https://community.adaptlearning.org/
24 stars 21 forks source link

register is sending @null on the end of the server request #159

Closed oliverfoster closed 2 years ago

oliverfoster commented 2 years ago

https://github.com/adaptlearning/adapt-cli/blob/2ed95f94a7bd6816178bdd62332e094b61b73a53/lib/integration/Plugin.js#L375-L378

  1. should return name when projectVersion === null

  2. server should also check that name is valid before allowing register https://github.com/adaptlearning/node-bower-server/blob/0f9c8ceef25d717637a67b8b9f5da6dcc51d4a13/webserver.js#L78 should have no spaces, at signs or hash signs in at a minimum

oliverfoster commented 2 years ago

https://github.com/adaptlearning/adapt-cli/commit/55a4281570a589e9de606d7739ea1a47e10fd862