adaptlearning / adapt-cli

Command line and library interface for the Adapt Framework
https://community.adaptlearning.org/
24 stars 21 forks source link

Error: read ECONNRESET at TLSWrap.onStreamRead (node:internal/stream_base_commons:217:20) #169

Closed oliverfoster closed 1 year ago

oliverfoster commented 2 years ago

Original issue https://github.com/adaptlearning/adapt-cli/pull/165 error.txt issue.517-console.txt issue517-terminal.txt

https://github.com/adaptlearning/adapt-cli/pull/165#issuecomment-1135915001

@KristofferBroberg could you try to replicate your issue using the above changes?

I want to see what's in those stderr and error variable.

Tested:

source: null, stderr: 'Error: read ECONNRESET\n' + ' at TLSWrap.onStreamRead (node:internal/stream_base_commons:217:20) {\n' + ' errno: -54,\n' + " code: 'ECONNRESET',\n" + " syscall: 'read'\n" + '}\n' + ...a bunch of NPM notices

From what I can tell/guess my installation is corrupt and @danielstorey's input is more relevant for this issue.

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 3.0.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

taylortom commented 1 year ago

The process.exit in econnreset.js is also causing the AAT to quit if there are any uncaught exceptions thrown by the app.

Is there any way we can configure it to only run when in CLI mode?

oliverfoster commented 1 year ago

We can remove the process.exit and just have it log errors?

taylortom commented 1 year ago

Yep that works for me 😄

It's generally not a massive problem, and has come in handy for any errors I've forgotten to catch properly, but would be good if we didn't have the exit.