search

adaptlearning / adapt-contrib-assessmentResults

A component used to display a single assessment's results.
GNU General Public License v3.0
2 stars 25 forks source link

Adapt Framework Issue/#1955 #40

Closed jamesrea83 closed 6 years ago

jamesrea83 commented 6 years ago

re https://github.com/adaptlearning/adapt_framework/issues/1955

OscarArango commented 6 years ago

Not sure if this is related, but apparently now when using the shortcodes, when viewing the course, it no longer pulls the data, instead it shows the {{{score}}} as it's written with the rest of the text. This is on:

Adapt Authoring 0.4.1 framework 2.2.5

thanks,

moloko commented 6 years ago

@OscarArango just to be clear, are you saying that happens when you apply the changes in this pull request?

moloko commented 6 years ago

@jamesrea83 there are some comments from the original PR that you need to take into account here.

OscarArango commented 6 years ago

@moloko i'm not sure it has anything to do with this build. Unfortunately GitHub has no way to list bugs or issues that I can see. I end up posting under pull requests so that the issue doesn't go unnoticed. I shouldn't post here, but it's like I have to let the developer know. If I should post somewhere other then here please let me know. Adapt forum was not a good place since most posts get buried.

moloko commented 6 years ago

@OscarArango if you look in bower.json for any plugin there should be a link for where to log issues. For the framework or any of the plugins supported by the core team it'll always be https://github.com/adaptlearning/adapt_framework/issues/new

with regards to this particular problem you might want to have a look at this post before logging an issue

OscarArango commented 6 years ago

Thanks Matt,

Your response was super helpful, I’ll be sure to use the proper channel next time. As for the issue I was having, your answer is correct, old theme overwriting the new theme files. Thanks a million for this response.

Thanks,

From: Matt Leathes [mailto:notifications@github.com] Sent: Friday, June 15, 2018 3:28 PM To: adaptlearning/adapt-contrib-assessmentResults Cc: Oscar Arango; Mention Subject: Re: [adaptlearning/adapt-contrib-assessmentResults] Adapt Framework Issue/#1955 (#40)

@OscarArango https://github.com/OscarArango if you look in bower.json for any plugin there should be a link for where to log issues. For the framework or any of the plugins supported by the core team it'll always be https://github.com/adaptlearning/adapt_framework/issues/new

with regards to this particular problem you might want to have a look at this post https://community.adaptlearning.org/mod/forum/discuss.php?d=2234 before logging an issue

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adaptlearning/adapt-contrib-assessmentResults/pull/40#issuecomment-397720375 , or mute the thread https://github.com/notifications/unsubscribe-auth/AFBTUVVD4ueywS_pyuen-qkmPGhHUquNks5t9AragaJpZM4Ua6LJ . https://github.com/notifications/beacon/AFBTUVykpPVzZi4v2w-b0idO2lO0i6m5ks5t9AragaJpZM4Ua6LJ.gif

jamesrea83 commented 6 years ago

Apologies, this one is getting complicated. Moving to new PR.