Closed kirsty-hames closed 2 months ago
Not sure if it's worth mentioning but this development is only available to the Framework at present until a core contentobject.model.schema
file is updated to offer up the flexibility to the AAT ( if that is something we want to do ).
Not sure if it's worth mentioning but this development is only available to the Framework at present until a core
contentobject.model.schema
file is updated to offer up the flexibility to the AAT ( if that is something we want to do ).
Thanks @guywillis. That's right and it's the same case for all other plugins that also use the image template. I'll update the PR message to note this.
Plugin README, example.json and schemas only include the image sources they were initially developed to support although they all support the full device range within the FW. For example, GMCQ supports small
and large
, whilst Accordion only supports src
.
If we want to extend support for AAT would we be best to do this globally for all plugin images or at least look at this holistically?
If we want to extend support for AAT would we be best to do this globally for all plugin images or at least look at this holistically?
We'd want to implement a consistent approach globally but is outside the scope of this PR. One to bring to the weekly stand up.
If we want to extend support for AAT would we be best to do this globally for all plugin images or at least look at this holistically?
We'd want to implement a consistent approach globally but is outside the scope of this PR. One to bring to the weekly stand up.
Just FYI I've raised an issue for this https://github.com/adaptlearning/adapt-contrib-core/issues/563
:tada: This PR is included in version 7.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Fixes https://github.com/adaptlearning/adapt-contrib-boxMenu/issues/198
Update
New
small
,medium
,large
andxlarge
.small
andlarge
images are defined, images switch fromsmall
tolarge
atmedium
(for separate mobile and desktop images). Note, this development is only available to the Framework at present until a core contentobject.model.schema file is updated to offer up the flexibility to the AAT. This is also the case for all other plugins that use the image template.Testing
Please test the following use cases. All code snippets reference pre-bundled course images.
Dependencies
Now that
.boxmenu-item__image-container
is a<span>
(not<div>
), Vanillamargin-bottom
is no longer supported (inline elements only support horizontal margins). Instead, I'd suggest applying themargin
to.boxmenu-item__details
as per below. See Vanilla issue https://github.com/adaptlearning/adapt-contrib-vanilla/issues/520