search

adaptlearning / adapt-contrib-boxMenu

A simple contributed menu based upon a grid system
GNU General Public License v3.0
2 stars 29 forks source link

Fix: Removing false catchall from tests #203

Closed cahirodoherty-learningpool closed 3 weeks ago

cahirodoherty-learningpool commented 1 month ago

Fixes #202

Fix

cahirodoherty-learningpool commented 1 month ago

@oliverfoster I've made an update based on your suggestion of bypassing the tests if the plugin isn't included in the build

oliverfoster commented 1 month ago

Can we do this in the task runner rather than the tests?

cahirodoherty-learningpool commented 1 month ago

Hmmm good point. It would be safer than having to include that before check on each test

oliverfoster commented 1 month ago

Yeahs, I know jest has a filter option. I'm not sure about cypress. If there isn't a good filter option for both, the opposite way of doing it, rather than excludes, is to only include the includes when an open (no specific file) execution is started.

cahirodoherty-learningpool commented 3 weeks ago

https://github.com/adaptlearning/adapt_framework/issues/3595