adaptlearning / adapt-contrib-core

Adapt Framework kernel. Responsible for boot loading, data loading and core APIs.
GNU General Public License v3.0
3 stars 17 forks source link

Mobile body and instruction behave differently #538

Closed swashbuck closed 5 months ago

swashbuck commented 6 months ago

Subject of the issue

When _isNarrativeOnMobile is true, both mobileBody and mobileInstruction are correctly shown on mobile. However, when _isNarrativeOnMobile is false, only mobileInstruction is shown on mobile and the body text uses body (not mobileBody).

mobileBody should always be shown on mobile view regardless of the value of _isNarrativeOnMobile.

We should also check whether the issue is present or caused by the Narrative plugin.

swashbuck commented 6 months ago

I believe this is actually an issue with adapt-contrib-core. In the header.jsx template, we only check for the existence of mobileInstruction instead of both that and mobileBody.