search

adaptlearning / adapt-contrib-core

Adapt Framework kernel. Responsible for boot loading, data loading and core APIs.
GNU General Public License v3.0
3 stars 17 forks source link

Fix: heading completion selector added to aria-label (fixes #561) #562

Closed kirsty-hames closed 2 months ago

kirsty-hames commented 2 months ago

Fixes https://github.com/adaptlearning/adapt-contrib-core/issues/561

Fix

Added .js-a11y-completion-description selector to heading completion aria-label instead of targeting generic .aria-label selector to update completion.

This will prevent functionality clashes between elements of a shared selector. For example, using a11y_alt_text helper within a displayTitle, as per the associated issue.

Testing

  1. Use the a11y_alt_text helper within a displayTitle. Note, you'll need to test this on a component that requires interaction rather than in view completion. For example, an Accordion title. "displayTitle": "I wish I had {{a11y_alt_text '$5bn' 'five billion dollars'}}",

  2. Go to the title within your course and inspect (or use a screen reader). Title should read "Incomplete. I wish I had five billion dollars"

  3. Interact with component so all items complete. Title should read "Complete. I wish I had five billion dollars"

oliverfoster commented 2 months ago

:tada: This PR is included in version 6.53.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: