adaptlearning / adapt-contrib-instructionError

An extension providing an accessible error for invalid question submissions reiterating the question instructions
GNU General Public License v3.0
0 stars 0 forks source link

No longer working? #11

Closed swashbuck closed 1 month ago

swashbuck commented 1 month ago

Subject of the issue

It seems that this plugin is no longer working or else I do not understand what it is meant to do.

Clicking the submit button for a question before the question can be submitted is not notifying me of the error. Since the question cannot yet be submitted, the button is disabled and has aria-disabled="true". This apparently means that you cannot interact with it. If I change the button to aria-disabled="false" and then try to submit without choosing an option, I get the Instruction Error popup:

Screenshot 2024-10-13 at 1 56 44 PM

Your environment

Steps to reproduce

  1. Enable Instruction Error.
// Add to course.json
"_instructionError": {
    "_isEnabled": true,
    "title": "Instructions",
    "body": "{{#if instruction}}{{{instruction}}}{{else}}Please complete the question and then select Submit.{{/if}}"
}
  1. Navigate to an MCQ
  2. Click the Submit button before choosing an option.

Expected behaviour

A Notify should appear because the question cannot yet be submitted.

Actual behaviour

Nothing happens.