Closed bell87 closed 8 years ago
Yeah looking at it, strapline
is more typically used as a title for the item rather than an instruction
+1
+1
The same change was approved and merged in the hotgraphic component: https://github.com/adaptlearning/adapt-contrib-hotgraphic/commit/97e70d801ce95bade046174ff9e4ffb857c4ed57
@bell87 yeah I appreciate that but in retrospect it was an error - using strapline
in this way results in a doubling up of instruction text:
this is what it should look like:
Hi @moloko in the interest of consistency I've reverted the hotgraphic component strapline default value back to the way it was: https://github.com/adaptlearning/adapt-contrib-hotgraphic/pull/132
@bell87 - excellent, thanks. sorry for not spotting this in the original PR
@bell87 do you want to change this so that it's just 'default value for _setCompletionOn
'? That sounds like a useful change.
anything more to be done on this or can I close?
This can be closed.
maybe a more standard word used in place of 'Tap'? Perhaps 'Click' or 'Select'.