adaptlearning / adapt-contrib-narrative

A component that displays an image gallery with accompanying text
GNU General Public License v3.0
5 stars 39 forks source link

Added default text for strapline and changed default value for _setCompletionOn #162

Closed bell87 closed 8 years ago

chucklorenz commented 8 years ago

maybe a more standard word used in place of 'Tap'? Perhaps 'Click' or 'Select'.

moloko commented 8 years ago

Yeah looking at it, strapline is more typically used as a title for the item rather than an instruction

ryan-lynch commented 8 years ago

+1

dennis-learningpool commented 8 years ago

+1

bell87 commented 8 years ago

The same change was approved and merged in the hotgraphic component: https://github.com/adaptlearning/adapt-contrib-hotgraphic/commit/97e70d801ce95bade046174ff9e4ffb857c4ed57

moloko commented 8 years ago

@bell87 yeah I appreciate that but in retrospect it was an error - using strapline in this way results in a doubling up of instruction text: 2016-05-24 12_40_29-adapt version 2 0 demonstration _ presentation components

moloko commented 8 years ago

this is what it should look like: shouldbe

bell87 commented 8 years ago

Hi @moloko in the interest of consistency I've reverted the hotgraphic component strapline default value back to the way it was: https://github.com/adaptlearning/adapt-contrib-hotgraphic/pull/132

moloko commented 8 years ago

@bell87 - excellent, thanks. sorry for not spotting this in the original PR

moloko commented 8 years ago

@bell87 do you want to change this so that it's just 'default value for _setCompletionOn'? That sounds like a useful change.

moloko commented 8 years ago

anything more to be done on this or can I close?

brian-learningpool commented 8 years ago

This can be closed.