search

adaptlearning / adapt-contrib-narrative

A component that displays an image gallery with accompanying text
GNU General Public License v3.0
5 stars 39 forks source link

Fixes tabbing issue #167

Closed andrewhosgood closed 6 years ago

andrewhosgood commented 7 years ago

Issue caused by https://github.com/adaptlearning/adapt-contrib-narrative/commit/36e31c1f21c802dea794328ebd78f9fc6ec869bc affects tab order, making images in narrative items tabbable.

This update removes the images from the tab order, which should now be:

  1. Component title
  2. Component body
  3. Component instruction
  4. Image label
  5. Content title
  6. Content body
  7. Previous button (if available, loop to 4 if clicked)
  8. Next button (if available, loop to 4 if clicked)
  9. Component state
moloko commented 7 years ago

I'm not sure if it's a problem or not - but in Firefox I get a different tab order to the above - it's as above until after 6. when it tabs to div.narrative-slide-container before continuing on with 7. and 8. as above...

Seems fine in Chrome and - more importantly for accessibility - in IE11.

moloko commented 6 years ago

closing this as the recent rebuild of this plugin has likely made it too out of date to use, plus the upcoming Adapt accessibility refactor will also make it unnecessary