ItemsComponentModel

[lc-thomasberger]

use ItemsComponentModel improve animation performance

• use transform (no layout trashing)
• use css transition

[lc-thomasberger]

requires these changes in the Framework

[tomgreenfield]

Is there meant to be a visited state?

[lc-thomasberger]

@tomgreenfield done

[chucklorenz]

.narrative-item-title appears in narrative.less, but I cannot find it in narrative.hbs. Is it supposed to be .narrative-content-title?

[moloko]

also just to check whether this PR will require a fix for https://github.com/adaptlearning/adapt_framework/issues/2100

[moloko]

FYI tested in FF and IE11, checked that:

• _hasNavigationInTextArea: true
• _setCompletionOn: "inview"
• graphic attribution

all work OK

[moloko]

Sorry @lc-thomasberger but it looks like something's gone a bit wrong with the _hasNavigationInTextArea layout following that last set of updates:

[lc-thomasberger]

@moloko it is this line in the theme https://github.com/adaptlearning/adapt-contrib-vanilla/blob/master/less/src/narrative.less#L44

[moloko]

@lc-thomasberger OK so from what I can see it's this which is overriding this in the theme.

For reference, this is how it how it looks in the current version of narrative when "_hasNavigationInTextArea": true:

(As I recall, it was decided that we'd have the .narrative-controls beneath the .narrative-indicators so that you could fit more narrative items in when using this layout)

So I think all that needs to be done is to remove these lines and we're then back to the same layout we have currently.