adaptlearning / adapt-contrib-narrative

A component that displays an image gallery with accompanying text
GNU General Public License v3.0
5 stars 39 forks source link

accessibility: issue/#2193 General accessibility fixes #183

Closed oliverfoster closed 5 years ago

oliverfoster commented 6 years ago

#2193

List of outstanding PRs: https://github.com/adaptlearning/adapt_framework/issues/2206.

oliverfoster commented 6 years ago

Like that?

moloko commented 6 years ago

Do we need the example JSON and README updating with that _ariaLevel attribute?

We do indeed. And can I just check it's correct that it's defaulted to 0 in properties.schema?

oliverfoster commented 5 years ago

I'd like to put the _ariaLevel bits in the core readme. The are only meant as overrides on the components.

oliverfoster commented 5 years ago

Default 0 is equivalent to "not set" as heading level 0 doesn't exist

oliverfoster commented 5 years ago

@lc-thomasberger could you re +1?