search

adaptlearning / adapt-contrib-narrative

A component that displays an image gallery with accompanying text
GNU General Public License v3.0
5 stars 39 forks source link

Fix compatibility with framework 3 #186

Closed tomgreenfield closed 5 years ago

tomgreenfield commented 5 years ago

Resolves https://github.com/adaptlearning/adapt_framework/issues/2348.

brian-learningpool commented 5 years ago

Should this be targeted at a v3-fixes branch though rather than master?

tomgreenfield commented 5 years ago

Needs to be master and released as v4.0.1 due to the way the CLI and authoring tool queries the latest compatibile version.

brian-learningpool commented 5 years ago

Couldn't we just re-tag 4.0 with the correct framework dependency?

tomgreenfield commented 5 years ago

Bit late in the day for that I'm afraid – it won't fix already broken installations.

brian-learningpool commented 5 years ago

I know broken installations can't be corrected without upgrading the plugin, but wouldn't it correct the plugin versioning going forward at least? E.g.

3.0.3 - framework: >=3.2
4.0.1 - framework: >=4.0

Meanwhile 4.0.0 is re-tagged with framework: >=4.0 in order to correct future CLI installations.

tomgreenfield commented 5 years ago

Superceded by #187 & #188.