search

adaptlearning / adapt-contrib-narrative

A component that displays an image gallery with accompanying text
GNU General Public License v3.0
5 stars 39 forks source link

Update narrative.hbs #193

Closed kunjsharma closed 5 years ago

kunjsharma commented 5 years ago

Added title existence check on narrative-content-title so can add content without title otherwise it add empty elements if no title given.

moloko commented 5 years ago

hi @kunjsharma thanks for this, would you mind ensuring that there's always a matching issue for each PR though? it might be worth having a quick read of our guide to contributing code

kunjsharma commented 5 years ago

Thanks @moloko , much appreciated.

moloko commented 5 years ago

@kunjsharma did you mean to close this?

kunjsharma commented 5 years ago

Yes please. I realize apart from guide to contributing code ,this change seems specific so reverted the fork.