search

adaptlearning / adapt-contrib-narrative

A component that displays an image gallery with accompanying text
GNU General Public License v3.0
5 stars 39 forks source link

Active item setting must conform to available range of number of items #199

Closed cahirodoherty-learningpool closed 4 years ago

cahirodoherty-learningpool commented 4 years ago

For issue #2742

moloko commented 4 years ago

@cahirodoherty-learningpool is there a matching issue for this PR?

cahirodoherty-learningpool commented 4 years ago

@cahirodoherty-learningpool is there a matching issue for this PR?

@moloko I have updated the PR description

cahirodoherty-learningpool commented 4 years ago

@moloko Thanks for the suggestions. I have implemented the code that could be confined to Narrative component

moloko commented 4 years ago

@moloko Thanks for the suggestions. I have implemented the code that could be confined to Narrative component

I think that's OK for the FWv3+ compatible version of narrative but I think for v4 and v5 it should be done in ItemsComponentModel.js