search

adaptlearning / adapt-contrib-narrative

A component that displays an image gallery with accompanying text
GNU General Public License v3.0
5 stars 39 forks source link

Issue 2742 Prevent active item setting beyond range of children #201

Closed cahirodoherty-learningpool closed 4 years ago

cahirodoherty-learningpool commented 4 years ago

https://github.com/adaptlearning/adapt_framework/issues/2742

moloko commented 4 years ago

are you sure this actually needs doing for v5? this line should handle it I think? no such check exists in the v3.x version of ItemsComponentModel which is why it needed fixing for that version

cahirodoherty-learningpool commented 4 years ago

are you sure this actually needs doing for v5? this line should handle it I think? no such check exists in the v3.x version of ItemsComponentModel which is why it needed fixing for that version

You're right. I was aware of this at the time, but just had a thought that it needed to be put in. I'm happy to close this