search

adaptlearning / adapt-contrib-narrative

A component that displays an image gallery with accompanying text
GNU General Public License v3.0
5 stars 39 forks source link

Support item titles in aria labels #203

Closed chris-steele closed 3 years ago

chris-steele commented 3 years ago

issue: https://github.com/adaptlearning/adapt_framework/issues/2921

moloko commented 3 years ago

using the titles feels a bit verbose. IMO it might be better to use something like 'Next item 3 of 3' - and this would provide more context since it would tell the learner exactly where in the narrative sequence they are.

equally could use an aria 'live' region to get the screenreader to announce the page count as it changes, as per https://www.w3.org/WAI/tutorials/carousels/working-example/

chris-steele commented 3 years ago

using the titles feels a bit verbose. IMO it might be better to use something like 'Next item 3 of 3' - and this would provide more context since it would tell the learner exactly where in the narrative sequence they are.

Thanks for the speedy review @moloko. Happy to make the pagination numerals available (e.g. as {{itemNum}}, {{itemCount}}) to the template to make it flexible; then end users can decide what is most appropriate?

moloko commented 3 years ago

flexible option sounds good to me. we have something similar in the hotgraphic popup pagination already https://github.com/adaptlearning/adapt-contrib-hotgraphic/blob/243e0aeb1ea77a61165662d204a5a2f013ce695d/properties.schema#L15-L23

chris-steele commented 3 years ago

Like it! After all, the customer knows best; that's what makes 'em so popular!