search

adaptlearning / adapt-contrib-narrative

A component that displays an image gallery with accompanying text
GNU General Public License v3.0
5 stars 39 forks source link

ADAPT-7911-narrative-issues-with-images-on-IE11 #208

Closed eleanor-heath closed 3 years ago

eleanor-heath commented 3 years ago

Linked issue: https://github.com/adaptlearning/adapt_framework/issues/3032

oliverfoster commented 3 years ago

Does it work with 3/6/7 & 9 items?

eleanor-heath commented 3 years ago

Does it work with 3/6/7 & 9 items?

yes

eleanor-heath commented 3 years ago

Does it work with 3/6/7 & 9 items?

yes

I have tried 2, 3, 4, 5 and 6 items and its working

eleanor-heath commented 3 years ago

will try 7 and 9 items now to be sure

oliverfoster commented 3 years ago

Yea, don't worry about equally divisible numbers. Just the ones which produce the overhanging subpixel. 5 is always fine, my mistake. It's normally just the multiples of 3 but sometimes others. And you'll want to check over different tablet sizes where the total space for division changes.

eleanor-heath commented 3 years ago

Closing this PR as Ive another PR open that resolves this issue here https://github.com/adaptlearning/adapt-contrib-narrative/pull/209