Adapt 7933 narrative attribution gets read after all of the items

adaptlearning / adapt-contrib-narrative

A component that displays an image gallery with accompanying text

GNU General Public License v3.0

5 stars 39 forks source link

Adapt 7933 narrative attribution gets read after all of the items #210

Closed eleanor-heath closed 3 years ago

eleanor-heath commented 3 years ago

resolves https://github.com/adaptlearning/adapt_framework/issues/3052

oliverfoster commented 3 years ago

I'll endeavour to test this with a SR today. :+1:

moloko commented 3 years ago

@oliverfoster do you think it's worth bumping the FW dependency to whatever-I-end-up-calling-the-current-master? or leave as-is and just include something in the release notes that it 'works best with v5.x'?

oliverfoster commented 3 years ago

A note or version bump would be fine (but not necessary) depending on which fw everyone is using?

The u-clearfix issue predates all of these changes. I only just worked out that it's an issue we can fix. Generally I've not been bothered about random blanks really, as they're mostly unavoidable.