adaptlearning / adapt-contrib-narrative

A component that displays an image gallery with accompanying text
GNU General Public License v3.0
5 stars 39 forks source link

_isMobileTextBelowImage back button issue #271

Closed swashbuck closed 12 months ago

swashbuck commented 1 year ago

Subject of the issue

When viewing on mobile with _isMobileTextBelowImage set to 'true'

Possibly related to https://github.com/adaptlearning/adapt-contrib-hotgraphic/issues/278

back-disabled

Your environment

Steps to reproduce

  1. On a Narrative, use _isMobileTextBelowImage: true
  2. View Narrative on a mobile device or at a mobile screen width with a non-mobile device.
  3. Click the Next button to go to item 2

Expected behaviour

Once item 2 is active, the Back button should be enabled.

Actual behaviour

Back button is not enabled.

kirsty-hames commented 12 months ago

I can replicate the issue described but I think it's specific to instances where the item (image and text) is greater than the screen height. For example, I can replicate this on my iPhone SE but not on an iPhone XR. I can avoid the issue on iPhone SE if I scroll each item into view before selecting the 'next' button.

swashbuck commented 12 months ago

I can replicate the issue described but I think it's specific to instances where the item (image and text) is greater than the screen height. For example, I can replicate this on my iPhone SE but not on an iPhone XR. I can avoid the issue on iPhone SE if I scroll each item into view before selecting the 'next' button.

That's odd. I wasn't able to reproduce the issue based on the heights. That said, I think I've fixed it now :)

github-actions[bot] commented 12 months ago

:tada: This issue has been resolved in version 7.4.10 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: