adaptlearning / adapt-contrib-narrative

A component that displays an image gallery with accompanying text
GNU General Public License v3.0
5 stars 39 forks source link

circle dots (below the image) are not clickable in Narrative component. please make them clickable as per the old version. #273

Closed rakeshkumar749 closed 1 year ago

rakeshkumar749 commented 1 year ago

Subject of the issue/enhancement/features

circle dots (below the image) are not clickable in Narrative component. please make them clickable as per the old version.

Your environment

Steps to reproduce

URL:- https://games4enjoy.in/demo/adapt/new_sample1/index.html#/id/64b4e4d6c21cbf265c2c2621 go the the above link and there are a forth component of Narrative and below the image there are 4 gray dots with 1 green dot and these dots are not clickable. However, in the older version these dots are clickable. please make them clickable.

Expected behaviour

In Narrative and below the image there are 4 gray dots with 1 green dot and these dots are not clickable. However, in the older version these dots are clickable. please make them clickable and hand cursor should appear on hover on these.

Actual behaviour

these dots are not clickable.

Screenshots (if you can)

image

oliverfoster commented 1 year ago

We removed the ability to click on them for better accessibility. There should be no functionality available to visual users that isn't available for keyboard, screen reader and non-sighted users.

  1. The indicators could not be accessed via the screen reader or keyboard as they contained no text and weren't focusable, clickable buttons with an accessible name.
  2. Making them accessible to the screen reader and keyboard would have given two sets of controls, the left/right arrows and the indicators for each narrative.
  3. It was felt that two navigation methods, the left/right arrows and the indicators was too much for a non-sighted, screen reader user.
  4. We removed the click from the indicators and kept only the left/right arrows.