Replace instruction logic is redundant - Githubissues

adaptlearning / adapt-contrib-narrative

A component that displays an image gallery with accompanying text

GNU General Public License v3.0

5 stars 39 forks source link

Replace instruction logic is redundant #281

Closed guywillis closed 8 months ago

guywillis commented 8 months ago

Subject of the issue

The replace instruction function is now controlled by the header.jsx template which makes this chunk of code redundant.

Narrative function https://github.com/adaptlearning/adapt-contrib-narrative/blob/4b737991ae810af3b4ab28eb7bcd0f2ee385e626/js/NarrativeView.js#L178-L187

Header.jsx https://github.com/adaptlearning/adapt-contrib-core/blob/e90414c74cdbb144cdabf4fd592e92bc5a790054/templates/header.jsx#L37-L39

Your environment

Master AT & FW

github-actions[bot] commented 8 months ago

:tada: This issue has been resolved in version 7.4.13 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: