search

adaptlearning / adapt-contrib-narrative

A component that displays an image gallery with accompanying text
GNU General Public License v3.0
5 stars 39 forks source link

Previous / next button item count ARIA is dependant on title #293

Closed kirsty-hames closed 5 months ago

kirsty-hames commented 5 months ago

Subject of the issue

Including the item count e.g. "Item 1 of 3", in the .narrative__controls aria-label is dependant on the item having a title.

When _items[].title is set,.narrative__controls aria-label reads as "Back to item title (item 1 of 3)".

When _items[].title is not set,.narrative__controls aria-label reads as "Back".

Expected behaviour

Include item count regardless as this is useful information.

So when _items[].title is not set,.narrative__controls aria-label reads as "Back (item 1 of 3)".

github-actions[bot] commented 5 months ago

:tada: This issue has been resolved in version 7.8.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: