search

adaptlearning / adapt-contrib-narrative

A component that displays an image gallery with accompanying text
GNU General Public License v3.0
5 stars 39 forks source link

Update: move previous/next item count ARIA outside of title condition (fixes #293) #294

Closed kirsty-hames closed 5 months ago

kirsty-hames commented 5 months ago

Including the item count e.g. "Item 1 of 3", in the .narrative__controls aria-label was dependant on the item having a title. Item count now reads regardless.

When _items[].title is set,.narrative__controls aria-label reads as "Back to item title (item 1 of 3)".

When _items[].title is not set,.narrative__controls aria-label reads as "Back (item 1 of 3)".

Fixes https://github.com/adaptlearning/adapt-contrib-narrative/issues/293

github-actions[bot] commented 5 months ago

:tada: This PR is included in version 7.8.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: