search

adaptlearning / adapt-contrib-narrative

A component that displays an image gallery with accompanying text
GNU General Public License v3.0
5 stars 39 forks source link

Migration: Use core mobileInstruction #302

Closed swashbuck closed 4 months ago

swashbuck commented 4 months ago

Subject of the enhancement

In this core PR, the mobileBody and mobileInstruction properties will be added to the core header template. The same mobileInstruction property specific to this plugin should be removed. However, migration scripts will be needed so that we do not break existing builds.

Dependencies

oliverfoster commented 4 months ago

I don't understand what this issue is describing.

The mobileInstruction behaviour is in core and then utilised by this plugin when it sets a property value. I don't believe there is any code in this plugin which manages mobileInstruction except the schema and example.json.

The core pr https://github.com/adaptlearning/adapt-contrib-core/pull/539 does not add inherited properties to the schema and it doesn't modify mobileInstruction which was there for this component to use already.

swashbuck commented 4 months ago

Ok, yep, makes sense. Will close this ticket.