search

adaptlearning / adapt-contrib-spoor

A basic scorm tracking plugin for Adapt
GNU General Public License v3.0
14 stars 42 forks source link

Uglifying source build/offline_API_wrapper.js failed #259

Closed swashbuck closed 1 year ago

swashbuck commented 1 year ago

Subject of the issue/enhancement/features

When building a new course, the uglify task fails with the following message:

Uglifying source build/offline_API_wrapper.js failed
Warning: Uglification failed.
Unexpected token: punc «.».
Line 79 in build/offline_API_wrapper.js

Your environment

Steps to reproduce

  1. Install a new course with adapt create course
  2. cd to the new directory
  3. Run grunt build

Expected behaviour

Successful build

Actual behaviour

Uglification task fails.

Potential cause

I believe it was caused by commit 479c2d. In required/offline_API_wrapper.js, lines 79 and 133 use the ES6 style Optional Chaining feature.

oliverfoster commented 1 year ago

Will need to bump the fw version required by spoor once the above pr is in.